summaryrefslogtreecommitdiff
path: root/drivers/ide/ide-gd.c
diff options
context:
space:
mode:
authorHugh Dickins <hugh.dickins@tiscali.co.uk>2009-06-10 16:37:20 +0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-06-10 16:37:20 +0400
commit5f4417a156a6e44359effa9492de3ed5638a9b13 (patch)
tree7868d60ce2c0b38b07727090c865d04fa93a622d /drivers/ide/ide-gd.c
parenta20b2a44eca52818ef52a94959480b7e6ea2f528 (diff)
downloadlinux-5f4417a156a6e44359effa9492de3ed5638a9b13.tar.xz
ide: fix PowerMac bootup oops
PowerMac bootup with CONFIG_IDE=y oopses in ide_pio_cycle_time(): because "ide: try to use PIO Mode 0 during probe if possible" causes pmac_ide_set_pio_mode() to be called before drive->id has been set. Bart points out other places which now need drive->id set earlier, so follow his advice to allocate it in ide_port_alloc_devices() (using kzalloc_node, without error message, as when allocating drive) and memset it for reuse in ide_port_init_devices_data(). Fixed in passing: ide_host_alloc() was missing ide_port_free_devices() from an error path. Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk> Cc: Joao Ramos <joao.ramos@inov.pt> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-gd.c')
0 files changed, 0 insertions, 0 deletions