diff options
| author | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2019-08-12 19:27:39 +0300 |
|---|---|---|
| committer | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2019-08-22 18:11:58 +0300 |
| commit | 87fcb6a69e54527ccaeb5878168cccdba9f6b6ae (patch) | |
| tree | e0aacd9f60504384cc942f0bdbb37ae9c7f04d63 /drivers/hid/hid-sensor-hub.c | |
| parent | 15d90b242290f228166ea79ee1cc2db6b31a2143 (diff) | |
| download | linux-87fcb6a69e54527ccaeb5878168cccdba9f6b6ae.tar.xz | |
HID: do not call hid_set_drvdata(hdev, NULL) in drivers
This is a common pattern in the HID drivers to reset the drvdata. Some
do it properly, some do it only in case of failure.
But, this is actually already handled by driver core, so there is no need
to do it manually.
[for hid-sensor-hub.c]
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[For hid-picolcd_core.c]
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Diffstat (limited to 'drivers/hid/hid-sensor-hub.c')
| -rw-r--r-- | drivers/hid/hid-sensor-hub.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index be92a6f79687..94c7398b5c27 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -742,7 +742,6 @@ static void sensor_hub_remove(struct hid_device *hdev) } spin_unlock_irqrestore(&data->lock, flags); mfd_remove_devices(&hdev->dev); - hid_set_drvdata(hdev, NULL); mutex_destroy(&data->mutex); } |