diff options
| author | Matthew Brost <matthew.brost@intel.com> | 2024-09-21 04:17:12 +0300 |
|---|---|---|
| committer | Matthew Brost <matthew.brost@intel.com> | 2024-09-24 19:03:42 +0300 |
| commit | fe4f5d4b661666a45b48fe7f95443f8fefc09c8c (patch) | |
| tree | 31e40d590d3f9fcce8d8f0b9ab4930b04e9bc382 /drivers/gpu/drm/xe/xe_device.c | |
| parent | 876253165f3eaaacacb8c8bed16a9df4b6081479 (diff) | |
| download | linux-fe4f5d4b661666a45b48fe7f95443f8fefc09c8c.tar.xz | |
drm/xe: Clean up VM / exec queue file lock usage.
Both the VM / exec queue file lock protect the lookup and reference to
the object, nothing more. These locks are not intended anything else
underneath them. XA have their own locking too, so no need to take the
VM / exec queue file lock aside from when doing a lookup and reference
get.
Add some kernel doc to make this clear and cleanup a few typos too.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240921011712.2681510-1-matthew.brost@intel.com
Diffstat (limited to 'drivers/gpu/drm/xe/xe_device.c')
| -rw-r--r-- | drivers/gpu/drm/xe/xe_device.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index cb5a9fd820cf..53dcece40fc5 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -171,10 +171,8 @@ static void xe_file_close(struct drm_device *dev, struct drm_file *file) xe_exec_queue_kill(q); xe_exec_queue_put(q); } - mutex_lock(&xef->vm.lock); xa_for_each(&xef->vm.xa, idx, vm) xe_vm_close_and_put(vm); - mutex_unlock(&xef->vm.lock); xe_file_put(xef); |