diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-06 16:27:42 +0300 |
|---|---|---|
| committer | Eric Anholt <eric@anholt.net> | 2019-07-16 02:26:43 +0300 |
| commit | 0a869e8d82efa43aaa09ff3c145cc98b01cd8a7c (patch) | |
| tree | b27196fc08bb3e6ba5b15c0bb2d26896632a9389 /drivers/gpu/drm/pl111 | |
| parent | 71866a56bc7594068d894bacd9ac957878c6816a (diff) | |
| download | linux-0a869e8d82efa43aaa09ff3c145cc98b01cd8a7c.tar.xz | |
drm/pl111: pl111_vexpress.c: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop there is
no put, thus causing a memory leak. Hence add an of_node_put before the
break.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190706132742.3250-1-nishkadg.linux@gmail.com
Diffstat (limited to 'drivers/gpu/drm/pl111')
| -rw-r--r-- | drivers/gpu/drm/pl111/pl111_vexpress.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c index 38c938c9adda..350570fe06b5 100644 --- a/drivers/gpu/drm/pl111/pl111_vexpress.c +++ b/drivers/gpu/drm/pl111/pl111_vexpress.c @@ -51,6 +51,7 @@ int pl111_vexpress_clcd_init(struct device *dev, } if (of_device_is_compatible(child, "arm,hdlcd")) { has_coretile_hdlcd = true; + of_node_put(child); break; } } |