diff options
| author | James Bottomley <James.Bottomley@HansenPartnership.com> | 2024-12-08 21:34:13 +0300 |
|---|---|---|
| committer | Ard Biesheuvel <ardb@kernel.org> | 2024-12-09 12:00:04 +0300 |
| commit | 2ab0837cb91b7de507daa145d17b3b6b2efb3abf (patch) | |
| tree | 0ae3eae0a5d4e089e1b04b2810a81cf19b9a7ab2 /drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | |
| parent | 0b2c29fb68f8bf3e87a9d88404aa6fdd486223e5 (diff) | |
| download | linux-2ab0837cb91b7de507daa145d17b3b6b2efb3abf.tar.xz | |
efivarfs: Fix error on non-existent file
When looking up a non-existent file, efivarfs returns -EINVAL if the
file does not conform to the NAME-GUID format and -ENOENT if it does.
This is caused by efivars_d_hash() returning -EINVAL if the name is not
formatted correctly. This error is returned before simple_lookup()
returns a negative dentry, and is the error value that the user sees.
Fix by removing this check. If the file does not exist, simple_lookup()
will return a negative dentry leading to -ENOENT and efivarfs_create()
already has a validity check before it creates an entry (and will
correctly return -EINVAL)
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: <stable@vger.kernel.org>
[ardb: make efivarfs_valid_name() static]
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c')
0 files changed, 0 insertions, 0 deletions