diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-08-08 02:00:16 +0300 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2021-08-12 23:34:13 +0300 |
| commit | d2c334f49c8305ff8ce31ea33183977a2935ba55 (patch) | |
| tree | 9d9fd8a90f586353b946eac9bd2292c8a993bed6 /drivers/bus/intel-ixp4xx-eb.c | |
| parent | 9c8300b1608748669b4b5b67e3fea71d07ca35af (diff) | |
| download | linux-d2c334f49c8305ff8ce31ea33183977a2935ba55.tar.xz | |
bus: ixp4xx: return on error in ixp4xx_exp_probe()
This code was intended to return an error code if regmap_read() fails
but the return statement was missing.
Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20210807230016.3607666-1-linus.walleij@linaro.org'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'drivers/bus/intel-ixp4xx-eb.c')
| -rw-r--r-- | drivers/bus/intel-ixp4xx-eb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/bus/intel-ixp4xx-eb.c b/drivers/bus/intel-ixp4xx-eb.c index 9acd00da413c..a4388440aca7 100644 --- a/drivers/bus/intel-ixp4xx-eb.c +++ b/drivers/bus/intel-ixp4xx-eb.c @@ -369,7 +369,7 @@ static int ixp4xx_exp_probe(struct platform_device *pdev) /* We check that the regmap work only on first read */ ret = regmap_read(eb->rmap, IXP4XX_EXP_CNFG0, &val); if (ret) - dev_err_probe(dev, ret, "cannot read regmap\n"); + return dev_err_probe(dev, ret, "cannot read regmap\n"); if (val & IXP4XX_EXP_CNFG0_MEM_MAP) eb->bus_base = IXP4XX_EXP_BOOT_BASE; else |