diff options
| author | Alexander Atanasov <alexander.atanasov@virtuozzo.com> | 2023-12-15 15:10:08 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2023-12-19 05:09:41 +0300 |
| commit | 066c5b46b6eaf2f13f80c19500dbb3b84baabb33 (patch) | |
| tree | a428125030363106921cb4e50bd71569b08e78e8 /drivers/ata/pata_atiixp.c | |
| parent | 08c94d80b2da481652fb633e79cbc41e9e326a91 (diff) | |
| download | linux-066c5b46b6eaf2f13f80c19500dbb3b84baabb33.tar.xz | |
scsi: core: Always send batch on reset or error handling command
In commit 8930a6c20791 ("scsi: core: add support for request batching") the
block layer bd->last flag was mapped to SCMD_LAST and used as an indicator
to send the batch for the drivers that implement this feature. However, the
error handling code was not updated accordingly.
scsi_send_eh_cmnd() is used to send error handling commands and request
sense. The problem is that request sense comes as a single command that
gets into the batch queue and times out. As a result the device goes
offline after several failed resets. This was observed on virtio_scsi
during a device resize operation.
[ 496.316946] sd 0:0:4:0: [sdd] tag#117 scsi_eh_0: requesting sense
[ 506.786356] sd 0:0:4:0: [sdd] tag#117 scsi_send_eh_cmnd timeleft: 0
[ 506.787981] sd 0:0:4:0: [sdd] tag#117 abort
To fix this always set SCMD_LAST flag in scsi_send_eh_cmnd() and
scsi_reset_ioctl().
Fixes: 8930a6c20791 ("scsi: core: add support for request batching")
Cc: <stable@vger.kernel.org>
Signed-off-by: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Link: https://lore.kernel.org/r/20231215121008.2881653-1-alexander.atanasov@virtuozzo.com
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/ata/pata_atiixp.c')
0 files changed, 0 insertions, 0 deletions