summaryrefslogtreecommitdiff
path: root/drivers/acpi/apei/bert.c
diff options
context:
space:
mode:
authorRandy Dunlap <rdunlap@infradead.org>2022-03-06 05:46:20 +0300
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2022-03-08 21:43:39 +0300
commitf3303ff649dbf7dcdc6a6e1a922235b12b3028f4 (patch)
tree446cdfab0967f5497d56b555f970638ca3c829a9 /drivers/acpi/apei/bert.c
parent27e932a31496f75b78ea41fd5ccadd0f75d8e8be (diff)
downloadlinux-f3303ff649dbf7dcdc6a6e1a922235b12b3028f4.tar.xz
ACPI: APEI: fix return value of __setup handlers
__setup() handlers should return 1 to indicate that the boot option has been handled. Returning 0 causes a boot option to be listed in the Unknown kernel command line parameters and also added to init's arg list (if no '=' sign) or environment list (if of the form 'a=b'). Unknown kernel command line parameters "erst_disable bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be passed to user space. Run /sbin/init as init process with arguments: /sbin/init erst_disable bert_disable hest_disable with environment: HOME=/ TERM=linux BOOT_IMAGE=/boot/bzImage-517rc6 Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support") Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support") Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Reviewed-by: "Huang, Ying" <ying.huang@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/apei/bert.c')
-rw-r--r--drivers/acpi/apei/bert.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
index 19e50fcbf4d6..86211422f4ee 100644
--- a/drivers/acpi/apei/bert.c
+++ b/drivers/acpi/apei/bert.c
@@ -77,7 +77,7 @@ static int __init setup_bert_disable(char *str)
{
bert_disable = 1;
- return 0;
+ return 1;
}
__setup("bert_disable", setup_bert_disable);