summaryrefslogtreecommitdiff
path: root/block/partitions/ultrix.c
diff options
context:
space:
mode:
authorMarek Vasut <marex@denx.de>2012-11-21 09:19:06 +0400
committerWolfram Sang <w.sang@pengutronix.de>2013-01-21 19:26:29 +0400
commit85de7fac3990cf0c0736edc83856add2e648c76a (patch)
tree1f6600aceb397d1e12ae372a8674f3ca7fc3f5f6 /block/partitions/ultrix.c
parent7d1f9aeff1ee4a20b1aeb377dd0f579fe9647619 (diff)
downloadlinux-85de7fac3990cf0c0736edc83856add2e648c76a.tar.xz
i2c: mxs: Fix misuse init_completion
The init_completion() call does reinit not only the variable carrying the flag that the completion finished, but also initialized the waitqueue associated with the completion. On the contrary, the INIT_COMPLETION() call only reinits the flag. In case there was anything still stuck in the waitqueue, subsequent call to init_completion() would be able to create possible race condition. This patch uses the proper function and moves init_completion() into .probe() call of the driver, to be issued only once. Note that such scenario is impossible, since two threads can never enter the mxs_i2c_xfer_msg(), since whole this section is protected by mutex in I2C core. This by no means allows this issue to exit though. Signed-off-by: Marek Vasut <marex@denx.de> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Diffstat (limited to 'block/partitions/ultrix.c')
0 files changed, 0 insertions, 0 deletions