summaryrefslogtreecommitdiff
path: root/block/blk-pm.h
diff options
context:
space:
mode:
authorXie Yongji <xieyongji@bytedance.com>2022-03-04 13:00:58 +0300
committerMichael S. Tsirkin <mst@redhat.com>2022-03-06 14:06:50 +0300
commite030759a1ddcbf61d42b6e996bfeb675e0032d8b (patch)
tree70775c214722e94d19e491586189eccda4d12bdc /block/blk-pm.h
parentdacc73ed0b88f1a787ec20385f42ca9dd9eddcd0 (diff)
downloadlinux-e030759a1ddcbf61d42b6e996bfeb675e0032d8b.tar.xz
virtio-blk: Remove BUG_ON() in virtio_queue_rq()
Currently we have a BUG_ON() to make sure the number of sg list does not exceed queue_max_segments() in virtio_queue_rq(). However, the block layer uses queue_max_discard_segments() instead of queue_max_segments() to limit the sg list for discard requests. So the BUG_ON() might be triggered if virtio-blk device reports a larger value for max discard segment than queue_max_segments(). To fix it, let's simply remove the BUG_ON() which has become unnecessary after commit 02746e26c39e("virtio-blk: avoid preallocating big SGL for data"). And the unused vblk->sg_elems can also be removed together. Fixes: 1f23816b8eb8 ("virtio_blk: add discard and write zeroes support") Suggested-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com> Link: https://lore.kernel.org/r/20220304100058.116-2-xieyongji@bytedance.com Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'block/blk-pm.h')
0 files changed, 0 insertions, 0 deletions