summaryrefslogtreecommitdiff
path: root/block/blk-merge.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2021-04-07 13:12:48 +0300
committerDavid S. Miller <davem@davemloft.net>2021-04-08 00:54:49 +0300
commit298b58f00c0f86868ea717426beb5c1198772f81 (patch)
tree1047fb0f44a0f88e33f9ec23331b19501c2086c6 /block/blk-merge.c
parent7b3ae17f0f681027a5de532c6a94d99334d97633 (diff)
downloadlinux-298b58f00c0f86868ea717426beb5c1198772f81.tar.xz
liquidio: Fix unintented sign extension of a left shift of a u16
The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port (a u16) left 24 places. There are two subtle issues here, first the shift gets promoted to an signed int and then sign extended to a u64. If oct->pcie_port is 0x80 or more then the upper bits get sign extended to 1. Secondly shfiting a u16 24 bits will lead to an overflow so it needs to be cast to a u64 for all the bits to not overflow. It is entirely possible that the u16 port value is never large enough for this to fail, but it is useful to fix unintended overflows such as this. Fix this by casting the port parameter to the macro to a u64 before the shift. Addresses-Coverity: ("Unintended sign extension") Fixes: 5bc67f587ba7 ("liquidio: CN23XX register definitions") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'block/blk-merge.c')
0 files changed, 0 insertions, 0 deletions