diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2023-02-02 16:49:13 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-02-07 20:20:59 +0300 |
| commit | f37bf75ca73d523ebaa7ceb44c45d8ecd05374fe (patch) | |
| tree | 20f48f05fc691267c0e6df9e2665b23ef2f960bb /block/bfq-iosched.h | |
| parent | 455944e4e439efc280da5f59ca6f5b014ac7b242 (diff) | |
| download | linux-f37bf75ca73d523ebaa7ceb44c45d8ecd05374fe.tar.xz | |
block, bfq: cleanup 'bfqg->online'
After commit dfd6200a0954 ("blk-cgroup: support to track if policy is
online"), there is no need to do this again in bfq.
However, 'pd->online' is not protected by 'bfqd->lock', in order to make
sure bfq won't see that 'pd->online' is still set after bfq_pd_offline(),
clear it before bfq_pd_offline() is called. This is fine because other
polices doesn't use 'pd->online' and bfq_pd_offline() will move active
bfqq to root cgroup anyway.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230202134913.2364549-1-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/bfq-iosched.h')
| -rw-r--r-- | block/bfq-iosched.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 75cc6a324267..69aaee52285a 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -1009,8 +1009,6 @@ struct bfq_group { /* reference counter (see comments in bfq_bic_update_cgroup) */ refcount_t ref; - /* Is bfq_group still online? */ - bool online; struct bfq_entity entity; struct bfq_sched_data sched_data; |