summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2021-05-09 14:33:48 +0300
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2021-05-17 15:54:27 +0300
commitf30172723ce270d6d60ac03748a6cbacc35b8f84 (patch)
treeff65b5ed020c8423004018c1104c4848f552bd80
parentdb27fdb33d10b582371f2be294d2b6b2ca501043 (diff)
downloadlinux-f30172723ce270d6d60ac03748a6cbacc35b8f84.tar.xz
iio: light: vcnl4035: Use pm_runtime_resume_and_get() to replace open coding.
Found using coccicheck script under review at: https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ This is a prequel to taking a closer look at the runtime pm in IIO drivers in general. Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Parthiban Nallathambi <pn@denx.de> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/20210509113354.660190-23-jic23@kernel.org
-rw-r--r--drivers/iio/light/vcnl4035.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 691a54b763e1..fd2f181b16db 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -144,9 +144,7 @@ static int vcnl4035_set_pm_runtime_state(struct vcnl4035_data *data, bool on)
struct device *dev = &data->client->dev;
if (on) {
- ret = pm_runtime_get_sync(dev);
- if (ret < 0)
- pm_runtime_put_noidle(dev);
+ ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
ret = pm_runtime_put_autosuspend(dev);