diff options
| author | Takashi Iwai <tiwai@suse.de> | 2025-06-10 09:43:19 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2025-06-10 09:45:33 +0300 |
| commit | ed29e073ba93f2d52832804cabdd831d5d357d33 (patch) | |
| tree | 3125f6a4b9808976873422e0b8eea82294433804 | |
| parent | 7b23887a0c70d15459f02c51651a111e9e5cab86 (diff) | |
| download | linux-ed29e073ba93f2d52832804cabdd831d5d357d33.tar.xz | |
ALSA: sb: Don't allow changing the DMA mode during operations
When a PCM stream is already running, one shouldn't change the DMA
mode via kcontrol, which may screw up the hardware. Return -EBUSY
instead.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=218185
Link: https://patch.msgid.link/20250610064322.26787-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/isa/sb/sb16_main.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sound/isa/sb/sb16_main.c b/sound/isa/sb/sb16_main.c index 74db11525003..c4930efd44e3 100644 --- a/sound/isa/sb/sb16_main.c +++ b/sound/isa/sb/sb16_main.c @@ -703,6 +703,9 @@ static int snd_sb16_dma_control_put(struct snd_kcontrol *kcontrol, struct snd_ct unsigned char nval, oval; int change; + if (chip->mode & (SB_MODE_PLAYBACK | SB_MODE_CAPTURE)) + return -EBUSY; + nval = ucontrol->value.enumerated.item[0]; if (nval > 2) return -EINVAL; |