summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>2025-01-04 16:56:05 +0300
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>2025-01-06 12:54:04 +0300
commiteca836dfd8386b32f1aae60f8e323218ac6a0b75 (patch)
tree5d8041e2abbed2875d608c477e85a917ad6add62
parent38405d3825d883b9e6ae680c14b530f79709533e (diff)
downloadlinux-eca836dfd8386b32f1aae60f8e323218ac6a0b75.tar.xz
soc: samsung: exynos-pmu: Fix uninitialized ret in tensor_set_bits_atomic()
If tensor_set_bits_atomic() is called with a mask of 0 the function will just iterate over its bit, not perform any updates and return stack value of 'ret'. Also reported by smatch: drivers/soc/samsung/exynos-pmu.c:129 tensor_set_bits_atomic() error: uninitialized symbol 'ret'. Fixes: 0b7c6075022c ("soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250104135605.109209-1-krzysztof.kozlowski@linaro.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
-rw-r--r--drivers/soc/samsung/exynos-pmu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
index d8c53cec7f37..dd5256e5aae1 100644
--- a/drivers/soc/samsung/exynos-pmu.c
+++ b/drivers/soc/samsung/exynos-pmu.c
@@ -126,7 +126,7 @@ static int tensor_set_bits_atomic(void *ctx, unsigned int offset, u32 val,
if (ret)
return ret;
}
- return ret;
+ return 0;
}
static bool tensor_is_atomic(unsigned int reg)