diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-04-06 09:40:14 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-09 11:30:34 +0300 |
| commit | e67c1cf1959503a5639cb5e642a3fa54e818ca4e (patch) | |
| tree | fe7f18abc133fea5c9ba355e28345361f00e97ca | |
| parent | ad5441fc854db3b0440b2a92b5db179df4bd0035 (diff) | |
| download | linux-e67c1cf1959503a5639cb5e642a3fa54e818ca4e.tar.xz | |
OPP: call of_node_put() on error path in _bandwidth_supported()
[ Upstream commit 907ed123b9d096c73e9361f6cd4097f0691497f2 ]
This code does not call of_node_put(opp_np) if of_get_next_available_child()
returns NULL. But it should.
Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/opp/of.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 440ab5a03df9..95b184fc3372 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table) /* Checking only first OPP is sufficient */ np = of_get_next_available_child(opp_np, NULL); + of_node_put(opp_np); if (!np) { dev_err(dev, "OPP table empty\n"); return -EINVAL; } - of_node_put(opp_np); prop = of_find_property(np, "opp-peak-kBps", NULL); of_node_put(np); |