diff options
| author | Tejun Heo <tj@kernel.org> | 2025-06-14 02:23:07 +0300 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2025-06-17 21:19:43 +0300 |
| commit | c50784e99f0e7199cdb12dbddf02229b102744ef (patch) | |
| tree | 5473b1e221d49fceffc8c43a16777f198bb8a51d | |
| parent | 47096d301e39f96962ca1fd6c7b71bfa796c53db (diff) | |
| download | linux-c50784e99f0e7199cdb12dbddf02229b102744ef.tar.xz | |
sched_ext: Make scx_group_set_weight() always update tg->scx.weight
Otherwise, tg->scx.weight can go out of sync while scx_cgroup is not enabled
and ops.cgroup_init() may be called with a stale weight value.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 819513666966 ("sched_ext: Add cgroup support")
Cc: stable@vger.kernel.org # v6.12+
| -rw-r--r-- | kernel/sched/ext.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 2c41c78be61e..33a0d8c6ff95 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -4241,12 +4241,12 @@ void scx_group_set_weight(struct task_group *tg, unsigned long weight) percpu_down_read(&scx_cgroup_rwsem); - if (scx_cgroup_enabled && tg->scx_weight != weight) { - if (SCX_HAS_OP(sch, cgroup_set_weight)) - SCX_CALL_OP(sch, SCX_KF_UNLOCKED, cgroup_set_weight, NULL, - tg_cgrp(tg), weight); - tg->scx_weight = weight; - } + if (scx_cgroup_enabled && SCX_HAS_OP(sch, cgroup_set_weight) && + tg->scx_weight != weight) + SCX_CALL_OP(sch, SCX_KF_UNLOCKED, cgroup_set_weight, NULL, + tg_cgrp(tg), weight); + + tg->scx_weight = weight; percpu_up_read(&scx_cgroup_rwsem); } |