diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2020-03-20 05:16:38 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-24 06:57:16 +0300 |
| commit | c31f0ea737e60845392f14ea657cb3abfce83856 (patch) | |
| tree | ed8c9087d1e9a8c10be8ca8db2a23acc41b0ba94 | |
| parent | 0dfb2d82af4cd70808de9720d37f8273c1237e52 (diff) | |
| download | linux-c31f0ea737e60845392f14ea657cb3abfce83856.tar.xz | |
mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources_register
When building arm32 allyesconfig:
ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by spectrum_cnt.c
>>> net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a
>>> did you mean: __aeabi_uidivmod
>>> defined in: arch/arm/lib/lib.a(lib1funcs.o)
pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms
do not error.
Fixes: ab8c4cc60420 ("mlxsw: spectrum_cnt: Move config validation along with resource register")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c index 0268f0a6662a..7974982533b5 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c @@ -303,7 +303,7 @@ int mlxsw_sp_counter_resources_register(struct mlxsw_core *mlxsw_core) } /* Check config is valid, no bank over subscription */ - if (WARN_ON(total_bank_config > pool_size / bank_size + 1)) + if (WARN_ON(total_bank_config > div64_u64(pool_size, bank_size) + 1)) return -EINVAL; return 0; |