diff options
| author | Steve French <stfrench@microsoft.com> | 2022-05-24 04:42:03 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-05-24 04:50:38 +0300 |
| commit | bbdf6cf56c88845fb0b713cbf5c6623c53fe40d8 (patch) | |
| tree | 24bc520471a7fc5bd7d1648f6c6b1411a8effdaf | |
| parent | 93ed91c020aa4f021600a633f1f87790a5e50b91 (diff) | |
| download | linux-bbdf6cf56c88845fb0b713cbf5c6623c53fe40d8.tar.xz | |
smb3: check for null tcon
Although unlikely to be null, it is confusing to use a pointer
before checking for it to be null so move the use down after
null check.
Addresses-Coverity: 1517586 ("Null pointer dereferences (REVERSE_INULL)")
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/smb2ops.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index cbe56ed35694..0d7feb9e609e 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -760,8 +760,8 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon, struct cifs_sb_info *cifs_sb, struct cached_fid **cfid) { - struct cifs_ses *ses = tcon->ses; - struct TCP_Server_Info *server = ses->server; + struct cifs_ses *ses; + struct TCP_Server_Info *server; struct cifs_open_parms oparms; struct smb2_create_rsp *o_rsp = NULL; struct smb2_query_info_rsp *qi_rsp = NULL; @@ -780,6 +780,9 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon, is_smb1_server(tcon->ses->server)) return -ENOTSUPP; + ses = tcon->ses; + server = ses->server; + if (cifs_sb->root == NULL) return -ENOENT; |