diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 11:41:04 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-27 23:45:15 +0300 |
| commit | ba23dc642dffd1a97dc08480acc788fdb8632425 (patch) | |
| tree | 091345bd62e495cac2c0d00b81718b5b4920098d | |
| parent | 6dff5add089f2cedd597937a3e39a01ebba8b7c8 (diff) | |
| download | linux-ba23dc642dffd1a97dc08480acc788fdb8632425.tar.xz | |
net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/sr9700.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 2d316c1b851b..6ac232e52bf7 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf) /* power up and reset phy */ sr_write_reg(dev, SR_PRR, PRR_PHY_RST); /* at least 10ms, here 20ms for safe */ - mdelay(20); + msleep(20); sr_write_reg(dev, SR_PRR, 0); /* at least 1ms, here 2ms for reading right register */ udelay(2 * 1000); |