summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2022-09-23 03:42:51 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-10-15 09:01:42 +0300
commitb42a64428abe1e3e5fe323e941e5c60399a27e1e (patch)
tree587a29683c87e6a145cb3ee3d35e37f5cdc73208
parente1f8820bf83f2bd0ad490a5bf4a81297551d464f (diff)
downloadlinux-b42a64428abe1e3e5fe323e941e5c60399a27e1e.tar.xz
random: clamp credited irq bits to maximum mixed
commit e78a802a7b4febf53f2a92842f494b01062d85a8 upstream. Since the most that's mixed into the pool is sizeof(long)*2, don't credit more than that many bytes of entropy. Fixes: e3e33fc2ea7f ("random: do not use input pool from hard IRQs") Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/char/random.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 0913aab28d9a..c594d9e92fc9 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -989,7 +989,7 @@ static void mix_interrupt_randomness(struct work_struct *work)
local_irq_enable();
mix_pool_bytes(pool, sizeof(pool));
- credit_init_bits(max(1u, (count & U16_MAX) / 64));
+ credit_init_bits(clamp_t(unsigned int, (count & U16_MAX) / 64, 1, sizeof(pool) * 8));
memzero_explicit(pool, sizeof(pool));
}