diff options
| author | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2025-06-19 20:35:37 +0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2025-06-24 22:11:02 +0300 |
| commit | b4102e35243338d966f73ade1fec66d88e8f55ac (patch) | |
| tree | 7b08bee28b5865bb3d17b601aa7656a99991348b | |
| parent | 4b443bbcd113cad6ec041a4f9f09179e2342ad60 (diff) | |
| download | linux-b4102e35243338d966f73ade1fec66d88e8f55ac.tar.xz | |
pinctrl: aw9523: fix mutex unlock in error path
We must unlock the mutex *after* the `out` label or we'd trigger a
deadlock in error path.
Fixes: dffe286e2428 ("pinctrl: aw9523: use new GPIO line value setter callbacks")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202506191952.A03cvn22-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/20250619173537.64298-1-brgl@bgdev.pl
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/pinctrl-aw9523.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9523.c index c84454038419..2935b2cceb03 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -652,9 +652,9 @@ static int aw9523_gpio_set_multiple(struct gpio_chip *chip, if (ret) goto out; } - mutex_unlock(&awi->i2c_lock); out: + mutex_unlock(&awi->i2c_lock); return ret; } |