diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-04 23:18:53 +0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-04 23:18:53 +0400 |
| commit | b1983cd897ec06080ec4884989c6a3f1e7ee7dce (patch) | |
| tree | 2bb86026350b0b7e511cf6578d37c9e43efd59ee | |
| parent | 61572bb1f40b9bec0acbb4d7bc0f5b33739f1ab1 (diff) | |
| download | linux-b1983cd897ec06080ec4884989c6a3f1e7ee7dce.tar.xz | |
create_mnt_ns: unidiomatic use of list_add()
while list_add(A, B) and list_add(B, A) are equivalent when both A and B
are guaranteed to be empty, the usual idiom is list_add(what, where),
not the other way round... Not a bug per se, but only by accident and
it makes RTFS harder for no good reason.
Spotted-by: Rajat Sharma <fs.rajat@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | fs/namespace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/namespace.c b/fs/namespace.c index b68eef2d592a..7b1ca9ba0b0a 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2463,7 +2463,7 @@ static struct mnt_namespace *create_mnt_ns(struct vfsmount *m) struct mount *mnt = real_mount(m); mnt->mnt_ns = new_ns; new_ns->root = mnt; - list_add(&new_ns->list, &mnt->mnt_list); + list_add(&mnt->mnt_list, &new_ns->list); } else { mntput(m); } |