diff options
| author | Nathan Lynch <ntl@pobox.com> | 2007-08-10 01:37:27 +0400 |
|---|---|---|
| committer | Paul Mackerras <paulus@samba.org> | 2007-08-17 05:01:54 +0400 |
| commit | b139f1fb0f1e4bfe06f2c88ba8c9a55d9513d871 (patch) | |
| tree | f0483fecba0a1f756357457e19692830cdc5bc36 | |
| parent | 8935fa0fe6f87c4df806f605de04aed4353c7600 (diff) | |
| download | linux-b139f1fb0f1e4bfe06f2c88ba8c9a55d9513d871.tar.xz | |
[POWERPC] Remove gratuitous reads from pasemi pci config space methods
The pasemi pci configuration space write method reads the written
location immediately after the write is performed, presumably in order
to flush the write. However, configuration space writes are not
allowed to be posted, making these reads gratuitous. Furthermore,
this behavior potentially causes us to violate the PCI PM spec when
changing between e.g. D0 and D3 states, because a delay of up to 10ms
may be required before the OS accesses configuration space after the
write which initiates the transition.
Remove the unnecessary reads from pa_pxp_write_config.
Signed-off-by: Nathan Lynch <ntl@pobox.com>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| -rw-r--r-- | arch/powerpc/platforms/pasemi/pci.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index 882b571ba92c..03d1d07aa2ac 100644 --- a/arch/powerpc/platforms/pasemi/pci.c +++ b/arch/powerpc/platforms/pasemi/pci.c @@ -107,15 +107,12 @@ static int pa_pxp_write_config(struct pci_bus *bus, unsigned int devfn, switch (len) { case 1: out_8(addr, val); - (void) in_8(addr); break; case 2: out_le16(addr, val); - (void) in_le16(addr); break; default: out_le32(addr, val); - (void) in_le32(addr); break; } return PCIBIOS_SUCCESSFUL; |