diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-03-15 13:04:24 +0300 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2025-03-18 15:09:00 +0300 |
| commit | ae85dabcef32a4cb841ec30792edbebb965345b2 (patch) | |
| tree | a92b4c4a9e0a871bb123309f3bb684f9b546d173 | |
| parent | 6cf5db71dc6d51ede4ff77cab126876ecf065048 (diff) | |
| download | linux-ae85dabcef32a4cb841ec30792edbebb965345b2.tar.xz | |
firmware: thead,th1520-aon: Fix use after free in th1520_aon_init()
Record the error code before freeing "aon_chan" to avoid a
use after free.
Fixes: e4b3cbd840e5 ("firmware: thead: Add AON firmware protocol driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/f19be994-d355-48a6-ab45-d0f7e5955daf@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/firmware/thead,th1520-aon.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/firmware/thead,th1520-aon.c b/drivers/firmware/thead,th1520-aon.c index 4416e9bbf854..38f812ac9920 100644 --- a/drivers/firmware/thead,th1520-aon.c +++ b/drivers/firmware/thead,th1520-aon.c @@ -203,6 +203,7 @@ struct th1520_aon_chan *th1520_aon_init(struct device *dev) { struct th1520_aon_chan *aon_chan; struct mbox_client *cl; + int ret; aon_chan = kzalloc(sizeof(*aon_chan), GFP_KERNEL); if (!aon_chan) @@ -217,8 +218,9 @@ struct th1520_aon_chan *th1520_aon_init(struct device *dev) aon_chan->ch = mbox_request_channel_byname(cl, "aon"); if (IS_ERR(aon_chan->ch)) { dev_err(dev, "Failed to request aon mbox chan\n"); + ret = PTR_ERR(aon_chan->ch); kfree(aon_chan); - return ERR_CAST(aon_chan->ch); + return ERR_PTR(ret); } mutex_init(&aon_chan->transaction_lock); |