diff options
| author | Mike Tipton <quic_mdtipton@quicinc.com> | 2024-08-09 08:21:29 +0300 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2024-08-15 22:14:54 +0300 |
| commit | a4e5af27e6f6a8b0d14bc0d7eb04f4a6c7291586 (patch) | |
| tree | 2f8c9770eeaafdb2e7fa76df1db3ba486f8f3551 | |
| parent | db30c1160ca5f115476cd8c8008f67572acb2c08 (diff) | |
| download | linux-a4e5af27e6f6a8b0d14bc0d7eb04f4a6c7291586.tar.xz | |
clk: qcom: clk-rpmh: Fix overflow in BCM vote
Valid frequencies may result in BCM votes that exceed the max HW value.
Set vote ceiling to BCM_TCS_CMD_VOTE_MASK to ensure the votes aren't
truncated, which can result in lower frequencies than desired.
Fixes: 04053f4d23a4 ("clk: qcom: clk-rpmh: Add IPA clock support")
Cc: stable@vger.kernel.org
Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
Reviewed-by: Taniya Das <quic_tdas@quicinc.com>
Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
Link: https://lore.kernel.org/r/20240809-clk-rpmh-bcm-vote-fix-v2-1-240c584b7ef9@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
| -rw-r--r-- | drivers/clk/qcom/clk-rpmh.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index bb82abeed88f..4acde937114a 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -263,6 +263,8 @@ static int clk_rpmh_bcm_send_cmd(struct clk_rpmh *c, bool enable) cmd_state = 0; } + cmd_state = min(cmd_state, BCM_TCS_CMD_VOTE_MASK); + if (c->last_sent_aggr_state != cmd_state) { cmd.addr = c->res_addr; cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state); |