summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChaehyun Lim <chaehyun.lim@gmail.com>2016-05-02 13:47:53 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-05-04 00:05:59 +0300
commit93dc5d5583e58e8cfa0355826396ac757e93f468 (patch)
tree4ed3b5324ede011d9f46567f288331f5d033887f
parentabfaf5fcd8be6c014d773139390d54d4611ef596 (diff)
downloadlinux-93dc5d5583e58e8cfa0355826396ac757e93f468.tar.xz
staging: wilc1000: change handle_get_mac_address's return type to void
When handle_get_mac_address is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/wilc1000/host_interface.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 8a269fd19ede..23bbaa8ae933 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -398,8 +398,8 @@ static void handle_get_ip_address(struct wilc_vif *vif, u8 idx)
netdev_err(vif->ndev, "Failed to get IP address\n");
}
-static s32 handle_get_mac_address(struct wilc_vif *vif,
- struct get_mac_addr *get_mac_addr)
+static void handle_get_mac_address(struct wilc_vif *vif,
+ struct get_mac_addr *get_mac_addr)
{
s32 result = 0;
struct wid wid;
@@ -412,13 +412,9 @@ static s32 handle_get_mac_address(struct wilc_vif *vif,
result = wilc_send_config_pkt(vif, GET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
- if (result) {
+ if (result)
netdev_err(vif->ndev, "Failed to get mac address\n");
- result = -EFAULT;
- }
complete(&hif_wait_response);
-
- return result;
}
static s32 handle_cfg_param(struct wilc_vif *vif,