summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGustavo A. R. Silva <garsilva@embeddedor.com>2017-05-24 12:18:52 +0300
committerLee Jones <lee.jones@linaro.org>2017-07-06 10:29:11 +0300
commit7b55033fbed07bad695ba744db3070c1cc351dc4 (patch)
tree686775423c95b19f1b7ee2e0f608ddc1cdbbe037
parent800e54558b0f1444e480ad4eb8d4a774899875d8 (diff)
downloadlinux-7b55033fbed07bad695ba744db3070c1cc351dc4.tar.xz
mfd: wm831x-spi: Add NULL check before pointer dereference
Add NULL check before dereferencing pointer of_id in order to avoid a potential NULL pointer dereference. Addresses-Coverity-ID: 1408830 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r--drivers/mfd/wm831x-spi.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c
index c332e2885b26..018ce652ae57 100644
--- a/drivers/mfd/wm831x-spi.c
+++ b/drivers/mfd/wm831x-spi.c
@@ -34,6 +34,10 @@ static int wm831x_spi_probe(struct spi_device *spi)
if (spi->dev.of_node) {
of_id = of_match_device(wm831x_of_match, &spi->dev);
+ if (!of_id) {
+ dev_err(&spi->dev, "Failed to match device\n");
+ return -ENODEV;
+ }
type = (enum wm831x_parent)of_id->data;
} else {
type = (enum wm831x_parent)id->driver_data;