diff options
| author | Yonghong Song <yonghong.song@linux.dev> | 2023-08-25 23:20:36 +0300 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-08-26 01:00:36 +0300 |
| commit | 76903a9648744c081547c91f31ec3917204b74e5 (patch) | |
| tree | 9c855c4c2f8c615aca9cdd71c6826a3c9802e08e | |
| parent | 33f0467fe06934d5e4ea6e24ce2b9c65ce618e26 (diff) | |
| download | linux-76903a9648744c081547c91f31ec3917204b74e5.tar.xz | |
kallsyms: Change func signature for cleanup_symbol_name()
All users of cleanup_symbol_name() do not use the return value.
So let us change the return value of cleanup_symbol_name() to
'void' to reflect its usage pattern.
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230825202036.441212-1-yonghong.song@linux.dev
Signed-off-by: Kees Cook <keescook@chromium.org>
| -rw-r--r-- | kernel/kallsyms.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index e12d26c10dba..18edd57b5fe8 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -163,12 +163,12 @@ unsigned long kallsyms_sym_address(int idx) return kallsyms_relative_base - 1 - kallsyms_offsets[idx]; } -static bool cleanup_symbol_name(char *s) +static void cleanup_symbol_name(char *s) { char *res; if (!IS_ENABLED(CONFIG_LTO_CLANG)) - return false; + return; /* * LLVM appends various suffixes for local functions and variables that @@ -178,12 +178,10 @@ static bool cleanup_symbol_name(char *s) * - foo.llvm.[0-9a-f]+ */ res = strstr(s, ".llvm."); - if (res) { + if (res) *res = '\0'; - return true; - } - return false; + return; } static int compare_symbol_name(const char *name, char *namebuf) |