diff options
| author | Xiu Jianfeng <xiujianfeng@huawei.com> | 2022-06-13 16:59:53 +0300 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2022-06-14 02:31:53 +0300 |
| commit | 73de1befcc53a7c68b0c5e76b9b5ac41c517760f (patch) | |
| tree | d15d49fa0a234bb3ae70fe702fde5bb96ce86e27 | |
| parent | 8d6d51edcb79b0906288170df165c1b86e278218 (diff) | |
| download | linux-73de1befcc53a7c68b0c5e76b9b5ac41c517760f.tar.xz | |
selinux: fix memleak in security_read_state_kernel()
In this function, it directly returns the result of __security_read_policy
without freeing the allocated memory in *data, cause memory leak issue,
so free the memory if __security_read_policy failed.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
[PM: subject line tweak]
Signed-off-by: Paul Moore <paul@paul-moore.com>
| -rw-r--r-- | security/selinux/ss/services.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c index 69b2734311a6..fe5fcf571c56 100644 --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -4048,6 +4048,7 @@ int security_read_policy(struct selinux_state *state, int security_read_state_kernel(struct selinux_state *state, void **data, size_t *len) { + int err; struct selinux_policy *policy; policy = rcu_dereference_protected( @@ -4060,5 +4061,11 @@ int security_read_state_kernel(struct selinux_state *state, if (!*data) return -ENOMEM; - return __security_read_policy(policy, *data, len); + err = __security_read_policy(policy, *data, len); + if (err) { + vfree(*data); + *data = NULL; + *len = 0; + } + return err; } |