diff options
| author | Karan Tilak Kumar <kartilak@cisco.com> | 2025-01-07 01:44:49 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2025-01-11 02:17:44 +0300 |
| commit | 5b6179d4b661e3c22ffa5f3fe2523bad4cd01983 (patch) | |
| tree | c59d3e6b63b4c9a18794a88716e70d19266a92da | |
| parent | 8f22f904b25b71c9e3e613e70944d818b203d6dc (diff) | |
| download | linux-5b6179d4b661e3c22ffa5f3fe2523bad4cd01983.tar.xz | |
scsi: fnic: Remove unnecessary else and unnecessary break in FDLS
Incorporate review comments from Martin:
Remove unnecessary else and unnecessary break to fix warnings
in the FDLS code.
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250106224451.3597-1-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/fnic/fdls_disc.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c index 2534af2fff53..2513a82a8915 100644 --- a/drivers/scsi/fnic/fdls_disc.c +++ b/drivers/scsi/fnic/fdls_disc.c @@ -2776,23 +2776,19 @@ fdls_process_tgt_prli_rsp(struct fnic_iport_s *iport, /*Retry Plogi again from the timer routine. */ tport->flags |= FNIC_FDLS_RETRY_FRAME; return; - } else { - FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, - "PRLI returned ELS_LS_RJT from target: 0x%x", - tgt_fcid); - - fdls_tgt_logout(iport, tport); - fdls_delete_tport(iport, tport); - return; } - break; + FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, + "PRLI returned ELS_LS_RJT from target: 0x%x", + tgt_fcid); + fdls_tgt_logout(iport, tport); + fdls_delete_tport(iport, tport); + return; default: atomic64_inc(&iport->iport_stats.tport_prli_misc_rejects); FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, "PRLI not accepted from target: 0x%x", tgt_fcid); return; - break; } FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, |