diff options
| author | Chenyuan Yang <chenyuan0y@gmail.com> | 2025-02-25 02:37:36 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2025-03-14 11:59:07 +0300 |
| commit | 4cdf1d2a816a93fa02f7b6b5492dc7f55af2a199 (patch) | |
| tree | 27b3a46cc4d387d6e5c42de65af0b4c86b88e284 | |
| parent | f4242e0e4d3609f89c39faa2d6b76b50082da18a (diff) | |
| download | linux-4cdf1d2a816a93fa02f7b6b5492dc7f55af2a199.tar.xz | |
mfd: ene-kb3930: Fix a potential NULL pointer dereference
The off_gpios could be NULL. Add missing check in the kb3930_probe().
This is similar to the issue fixed in commit b1ba8bcb2d1f
("backlight: hx8357: Fix potential NULL pointer dereference").
This was detected by our static analysis tool.
Cc: stable@vger.kernel.org
Fixes: ede6b2d1dfc0 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
Suggested-by: Lee Jones <lee@kernel.org>
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Link: https://lore.kernel.org/r/20250224233736.1919739-1-chenyuan0y@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/mfd/ene-kb3930.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c index fa0ad2f14a39..9460a67acb0b 100644 --- a/drivers/mfd/ene-kb3930.c +++ b/drivers/mfd/ene-kb3930.c @@ -162,7 +162,7 @@ static int kb3930_probe(struct i2c_client *client) devm_gpiod_get_array_optional(dev, "off", GPIOD_IN); if (IS_ERR(ddata->off_gpios)) return PTR_ERR(ddata->off_gpios); - if (ddata->off_gpios->ndescs < 2) { + if (ddata->off_gpios && ddata->off_gpios->ndescs < 2) { dev_err(dev, "invalid off-gpios property\n"); return -EINVAL; } |