diff options
| author | Geliang Tang <geliangtang@163.com> | 2015-11-16 18:30:00 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-11-17 01:21:48 +0300 |
| commit | 4736346bb47966254ee6d1fc50267a2609791cba (patch) | |
| tree | c5df986a482e3da96ef948ecebf2fe3203cbc280 | |
| parent | d09f9581b235a92abbe372531660b468fadabc17 (diff) | |
| download | linux-4736346bb47966254ee6d1fc50267a2609791cba.tar.xz | |
elevator: use list_{first,prev,next}_entry
To make the intention clearer, use list_{first,prev,next}_entry
instead of list_entry.
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | block/noop-iosched.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/block/noop-iosched.c b/block/noop-iosched.c index 3de89d4690f3..a163c487cf38 100644 --- a/block/noop-iosched.c +++ b/block/noop-iosched.c @@ -21,10 +21,10 @@ static void noop_merged_requests(struct request_queue *q, struct request *rq, static int noop_dispatch(struct request_queue *q, int force) { struct noop_data *nd = q->elevator->elevator_data; + struct request *rq; - if (!list_empty(&nd->queue)) { - struct request *rq; - rq = list_entry(nd->queue.next, struct request, queuelist); + rq = list_first_entry_or_null(&nd->queue, struct request, queuelist); + if (rq) { list_del_init(&rq->queuelist); elv_dispatch_sort(q, rq); return 1; @@ -46,7 +46,7 @@ noop_former_request(struct request_queue *q, struct request *rq) if (rq->queuelist.prev == &nd->queue) return NULL; - return list_entry(rq->queuelist.prev, struct request, queuelist); + return list_prev_entry(rq, queuelist); } static struct request * @@ -56,7 +56,7 @@ noop_latter_request(struct request_queue *q, struct request *rq) if (rq->queuelist.next == &nd->queue) return NULL; - return list_entry(rq->queuelist.next, struct request, queuelist); + return list_next_entry(rq, queuelist); } static int noop_init_queue(struct request_queue *q, struct elevator_type *e) |