diff options
| author | Sicelo A. Mhlongo <absicsz@gmail.com> | 2024-11-25 18:29:30 +0300 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2025-02-20 03:44:45 +0300 |
| commit | 45291874a762dbb12a619dc2efaf84598859007a (patch) | |
| tree | 63a31429460ec13c5f476bfb2a0220b9bc2b676e | |
| parent | a944cfd799e859753ad249372fa5d6d6d9300515 (diff) | |
| download | linux-45291874a762dbb12a619dc2efaf84598859007a.tar.xz | |
power: supply: bq27xxx_battery: do not update cached flags prematurely
Commit 243f8ffc883a1 ("power: supply: bq27xxx_battery: Notify also about
status changes") intended to notify userspace when the status changes,
based on the flags register. However, the cached state is updated too
early, before the flags are tested for any changes. Remove the premature
update.
Fixes: 243f8ffc883a1 ("power: supply: bq27xxx_battery: Notify also about status changes")
Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
Link: https://lore.kernel.org/r/20241125152945.47937-1-absicsz@gmail.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
| -rw-r--r-- | drivers/power/supply/bq27xxx_battery.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index a1d01791df01..6a1e4b6875d2 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1923,7 +1923,6 @@ static void bq27xxx_battery_update_unlocked(struct bq27xxx_device_info *di) cache.flags = -1; /* read error */ if (cache.flags >= 0) { cache.capacity = bq27xxx_battery_read_soc(di); - di->cache.flags = cache.flags; /* * On gauges with signed current reporting the current must be |