summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@linux.dev>2024-12-15 10:03:11 +0300
committerKent Overstreet <kent.overstreet@linux.dev>2025-01-10 07:38:41 +0300
commit30e32692d6b898338db26f6caf6fef295ce7ec68 (patch)
treef3e3b048695b09686620ed05abf82f8ab5b92562
parent6542afe299eaa1be530caa56c455492f470896cb (diff)
downloadlinux-30e32692d6b898338db26f6caf6fef295ce7ec68.tar.xz
bcachefs: Drop redundant "read error" call from btree_gc
The btree node read error path already calls topology error, so this is entirely redundant, and we're not specific enough about our error codes - this was triggering for bucket_ref_update() errors. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
-rw-r--r--fs/bcachefs/btree_gc.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
index 5aa11ca08c94..721dca551720 100644
--- a/fs/bcachefs/btree_gc.c
+++ b/fs/bcachefs/btree_gc.c
@@ -733,16 +733,8 @@ static int bch2_gc_btrees(struct bch_fs *c)
continue;
ret = bch2_gc_btree(trans, btree, true);
-
- if (mustfix_fsck_err_on(bch2_err_matches(ret, EIO),
- trans, btree_node_read_error,
- "btree node read error for %s",
- (printbuf_reset(&buf),
- bch2_btree_id_to_text(&buf, btree),
- buf.buf)))
- ret = bch2_btree_lost_data(c, btree);
}
-fsck_err:
+
printbuf_exit(&buf);
bch2_trans_put(trans);
bch_err_fn(c, ret);