diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2025-01-08 12:04:40 +0300 |
|---|---|---|
| committer | Petr Pavlu <petr.pavlu@suse.com> | 2025-03-10 13:54:44 +0300 |
| commit | 2bee017741f2890131da2fac96c3f2b64cb947b0 (patch) | |
| tree | aa4ff4699b19c04fe1c16e8521ff17e9fe853dd9 | |
| parent | 2ff49f8931be8bed53e65993fd1af68e3cd747cb (diff) | |
| download | linux-2bee017741f2890131da2fac96c3f2b64cb947b0.tar.xz | |
module: Use RCU in __is_module_percpu_address().
The modules list can be accessed under RCU assumption.
Use RCU protection instead preempt_disable().
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250108090457.512198-12-bigeasy@linutronix.de
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
| -rw-r--r-- | kernel/module/main.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/kernel/module/main.c b/kernel/module/main.c index af7ca713eff0..5d6f44c09bec 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -450,8 +450,7 @@ bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr) struct module *mod; unsigned int cpu; - preempt_disable(); - + guard(rcu)(); list_for_each_entry_rcu(mod, &modules, list) { if (mod->state == MODULE_STATE_UNFORMED) continue; @@ -468,13 +467,10 @@ bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr) per_cpu_ptr(mod->percpu, get_boot_cpu_id()); } - preempt_enable(); return true; } } } - - preempt_enable(); return false; } |