diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2011-01-06 13:50:29 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-01-10 02:45:48 +0300 |
| commit | 26877c794407855f65c056d7914b2e72ae9b93b8 (patch) | |
| tree | cc8e388d3a841fb089ea0fd3209b453e155a3dc2 | |
| parent | b5680e0b591f2701c5ba7d5fc8f96b55414073c8 (diff) | |
| download | linux-26877c794407855f65c056d7914b2e72ae9b93b8.tar.xz | |
hamradio: Resolve memory leak due to missing firmware release in add_mcs()
Failure to release_firmware() in drivers/net/hamradio/yam.c::add_mcs()
causes memory leak.
This patch should fix it.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/hamradio/yam.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 4e7d1d0a2340..7d9ced0738c5 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -396,7 +396,7 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate, while (p) { if (p->bitrate == bitrate) { memcpy(p->bits, bits, YAM_FPGA_SIZE); - return p->bits; + goto out; } p = p->next; } @@ -411,7 +411,7 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate, p->bitrate = bitrate; p->next = yam_data; yam_data = p; - + out: release_firmware(fw); return p->bits; } |