diff options
| author | Zhang Zhen <zhenzhang.zhang@huawei.com> | 2014-05-12 17:57:59 +0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2014-05-12 17:57:59 +0400 |
| commit | 230b8c1a7b388ac5e06549a7dbe083568875804e (patch) | |
| tree | d1291f679566ab473016a687e17c4155c7f3f6ea | |
| parent | 1c8349a17137b93f0a83f276c764a6df1b9a116e (diff) | |
| download | linux-230b8c1a7b388ac5e06549a7dbe083568875804e.tar.xz | |
ext4: avoid unneeded lookup when xattr name is invalid
In ext4_xattr_set_handle() we have checked the xattr name's length. So
we should also check it in ext4_xattr_get() to avoid unneeded lookup
caused by invalid name.
Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/xattr.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 4eec399ec807..c6ae6fab99be 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -369,6 +369,9 @@ ext4_xattr_get(struct inode *inode, int name_index, const char *name, { int error; + if (strlen(name) > 255) + return -ERANGE; + down_read(&EXT4_I(inode)->xattr_sem); error = ext4_xattr_ibody_get(inode, name_index, name, buffer, buffer_size); |