diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-01-12 09:59:41 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-02-01 03:19:01 +0300 |
| commit | 1c45256e599061021e2c848952e50f406457e448 (patch) | |
| tree | 4aab251a266dfb327ba5497faab9b62bbe81868e | |
| parent | 7a73190ea557e7f26914b0fe04c1f57a96cb771f (diff) | |
| download | linux-1c45256e599061021e2c848952e50f406457e448.tar.xz | |
netfs, fscache: Prevent Oops in fscache_put_cache()
[ Upstream commit 3be0b3ed1d76c6703b9ee482b55f7e01c369cc68 ]
This function dereferences "cache" and then checks if it's
IS_ERR_OR_NULL(). Check first, then dereference.
Fixes: 9549332df4ed ("fscache: Implement cache registration")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/e84bc740-3502-4f16-982a-a40d5676615c@moroto.mountain/ # v2
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | fs/fscache/cache.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/fscache/cache.c b/fs/fscache/cache.c index d645f8b302a2..9397ed39b0b4 100644 --- a/fs/fscache/cache.c +++ b/fs/fscache/cache.c @@ -179,13 +179,14 @@ EXPORT_SYMBOL(fscache_acquire_cache); void fscache_put_cache(struct fscache_cache *cache, enum fscache_cache_trace where) { - unsigned int debug_id = cache->debug_id; + unsigned int debug_id; bool zero; int ref; if (IS_ERR_OR_NULL(cache)) return; + debug_id = cache->debug_id; zero = __refcount_dec_and_test(&cache->ref, &ref); trace_fscache_cache(debug_id, ref - 1, where); |