diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-05-17 00:55:55 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-09 11:30:31 +0300 |
| commit | 1124e39fea0e2fdb4202f95b716cb97cc7de7cc7 (patch) | |
| tree | 7e99c591a3c161c1946d9e82a530a47a1006ef58 | |
| parent | 49ca50a98b3676c64a1fd02dd23989247e50b7ae (diff) | |
| download | linux-1124e39fea0e2fdb4202f95b716cb97cc7de7cc7.tar.xz | |
Input: sparcspkr - fix refcount leak in bbc_beep_probe
[ Upstream commit c8994b30d71d64d5dcc9bc0edbfdf367171aa96f ]
of_find_node_by_path() calls of_find_node_opts_by_path(),
which returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: 9c1a5077fdca ("input: Rewrite sparcspkr device probing.")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220516081018.42728-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/input/misc/sparcspkr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/input/misc/sparcspkr.c b/drivers/input/misc/sparcspkr.c index fe43e5557ed7..cdcb7737c46a 100644 --- a/drivers/input/misc/sparcspkr.c +++ b/drivers/input/misc/sparcspkr.c @@ -205,6 +205,7 @@ static int bbc_beep_probe(struct platform_device *op) info = &state->u.bbc; info->clock_freq = of_getintprop_default(dp, "clock-frequency", 0); + of_node_put(dp); if (!info->clock_freq) goto out_free; |