diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2023-04-29 23:36:04 +0300 |
|---|---|---|
| committer | Luis Chamberlain <mcgrof@kernel.org> | 2023-05-03 06:33:36 +0300 |
| commit | 0b891c83d8c54cb70e186456c2191adb5fd98c56 (patch) | |
| tree | 0548f3baa6761e6413ae519c05d35468e2876de3 | |
| parent | 348551ddaf311c76b01cdcbaf61b6fef06a49144 (diff) | |
| download | linux-0b891c83d8c54cb70e186456c2191adb5fd98c56.tar.xz | |
module: include internal.h in module/dups.c
Two newly introduced functions are declared in a header that is not
included before the definition, causing a warning with sparse or
'make W=1':
kernel/module/dups.c:118:6: error: no previous prototype for 'kmod_dup_request_exists_wait' [-Werror=missing-prototypes]
118 | bool kmod_dup_request_exists_wait(char *module_name, bool wait, int *dup_ret)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/module/dups.c:220:6: error: no previous prototype for 'kmod_dup_request_announce' [-Werror=missing-prototypes]
220 | void kmod_dup_request_announce(char *module_name, int ret)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Add an explicit include to ensure the prototypes match.
Fixes: 8660484ed1cf ("module: add debugging auto-load duplicate module support")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304141440.DYO4NAzp-lkp@intel.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
| -rw-r--r-- | kernel/module/dups.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/module/dups.c b/kernel/module/dups.c index aa8e1361fdb5..f3d7ea1e96d8 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -32,6 +32,8 @@ #include <linux/async.h> #include <linux/uaccess.h> +#include "internal.h" + #undef MODULE_PARAM_PREFIX #define MODULE_PARAM_PREFIX "module." static bool enable_dups_trace = IS_ENABLED(CONFIG_MODULE_DEBUG_AUTOLOAD_DUPS_TRACE); |