summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2025-03-12 11:31:57 +0300
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>2025-03-13 16:00:33 +0300
commit01db3d1ff43aeedeaf11c8bc9d09493ec00c8f4a (patch)
tree9707b5f87d2f03c97dfb69a871d9dc4fc3af0d80
parentf895f2493098b862f1ada0568aba278e49bf05b4 (diff)
downloadlinux-01db3d1ff43aeedeaf11c8bc9d09493ec00c8f4a.tar.xz
platform/x86/amd/pmc: fix leak in probe()
Call pci_dev_put(rdev) before returning. Fixes: 6ad1b2dc0f2a ("platform/x86/amd/pmc: Use managed APIs for mutex") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/65e2fffb-a1cb-4297-b725-661d6b790a05@stanley.mountain Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-rw-r--r--drivers/platform/x86/amd/pmc/pmc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd/pmc/pmc.c b/drivers/platform/x86/amd/pmc/pmc.c
index 84bc47009e5f..d789d6cab794 100644
--- a/drivers/platform/x86/amd/pmc/pmc.c
+++ b/drivers/platform/x86/amd/pmc/pmc.c
@@ -785,7 +785,7 @@ static int amd_pmc_probe(struct platform_device *pdev)
err = devm_mutex_init(dev->dev, &dev->lock);
if (err)
- return err;
+ goto err_pci_dev_put;
/* Get num of IP blocks within the SoC */
amd_pmc_get_ip_info(dev);