summaryrefslogtreecommitdiff
path: root/drivers/staging/rts5139
AgeCommit message (Collapse)AuthorFilesLines
2014-05-23staging: remove rts5139 driver codeGreg Kroah-Hartman27-20463/+0
Roger writes: Since all patches have been applied and the device is now supported by the new driver, would you remove the former staging one at drivers/staging/rts5139? Cc: Roger Tseng <rogerable@realtek.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rts5139: Make variables inside #ifdef CONFIG_PMGeert Uytterhoeven1-5/+7
If CONFIG_PM=n: drivers/staging/rts5139/rts51x_transport.c:649: warning: ‘media_not_present’ defined but not used drivers/staging/rts5139/rts51x_transport.c:651: warning: ‘invalid_cmd_field’ defined but not used Move the variables inside the #ifdef CONFIG_PM, and make them const while we're at it. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rts5139: fix bad symbol declarationNeil Armstrong3-6/+4
With sparse, the following error appears : CHECK drivers/staging/rts5139/ms_mg.c drivers/staging/rts5139/ms_mg.c:82:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static? Rename function with correct prefix and move declaration to coherent internal header file. Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16staging: rts5139: fixed coding styleThomas Tanaka1-9/+12
Fixed checkpatch warnings > 80 lines Signed-off-by: Thomas Tanaka <thomas.tanaka@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16Staging: rts5139: More appropriate use of sizeof operandFabio Falzoi1-1/+1
Use the pointer rts51x to get the size of the struct. Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16Staging: rts5139: Removed OOM messagesFabio Falzoi1-14/+3
All allocation Out Of Memory messages removed. We rely on the generic OOM message in dump_stack(). Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16Staging: rts5139: Use standard pr_<level> prefixingFabio Falzoi1-50/+50
Define pr_fmt macro to prefix every pr_<level> function in standard way. Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16Staging: rts5139: Splitted one-line multiple assignmentFabio Falzoi1-1/+2
Splitted a multiple assignment on two separate lines. Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16Staging: rts5139: Fixed multi-line code alignmentFabio Falzoi1-11/+10
Multi-line code aligned with open parenthesis. Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16Staging: rts5139: Camel case labels replacedFabio Falzoi1-9/+9
Replace camel case labels with linux coding style compliant names. Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-17staging: rts5139: Added in sd_cprm.c an include to fix a sparse warningAna Rey1-0/+1
Fix the following warnings from sparse in drivers/staging/rts5139/sd_cprm.c due to the missing include of sd_cprm.h Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-17staging: rts5139: make thrts5139_usb_idse local variable static in rts51x.cAna Rey1-1/+1
Make the local variable rts5139_usb_ids static Fix the following sparse warnings in rts51x.c CHECK drivers/staging/rts5139/rts51x.c drivers/staging/rts5139/rts51x.c:835:22: warning: symbol 'rts5139_usb_ids' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-17staging: rts5139: Added in ms_mg.c an include to fix a sparse warningAna Rey1-0/+1
Fix the following warnings from sparse in drivers/staging/rts5139/ms_mg.c due to the missing include of ms_mg.h drivers/staging/rts5139/ms_mg.c:81:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:122:5: warning: symbol 'rts51x_mg_set_leaf_id' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:173:5: warning: symbol 'rts51x_mg_get_local_EKB' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:232:5: warning: symbol 'rts51x_mg_chg' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:323:5: warning: symbol 'rts51x_mg_get_rsp_chg' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:392:5: warning: symbol 'rts51x_mg_rsp' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:450:5: warning: symbol 'rts51x_mg_get_ICV' was not declared. Should it be static? drivers/staging/rts5139/ms_mg.c:514:5: warning: symbol 'rts51x_mg_set_ICV' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-17staging: rts5139: make the local variable staticAna Rey1-2/+2
Make the local variable (media_not_present and invalid_cmd_field) static Fix the following sparse warnings in rts51x_transport.c drivers/staging/rts5139/rts51x_transport.c:649:4: warning: symbol 'media_not_present' was not declared. Should it be static? drivers/staging/rts5139/rts51x_transport.c:651:4: warning: symbol 'invalid_cmd_field' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-11drivers/staging/rts5139:xd.c: Fix line over 80 characters.Aybuke Ozdemir1-8/+10
Fix checkpatch.pl issues with line over 80 characters in xd.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-08staging: rts5139: Unnecessary space between function pointer name.Keerthimai Janarthanan1-2/+2
Unnecessary space between function pointer name. Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08Staging: rts5139: Fix Sparse Warning for Static Declarations in rts51x.cMonam Agarwal1-2/+2
This patch fixes the following sparse warning in rts51x.c drivers/staging/rts5139/rts51x.c:218:5: warning: symbol 'rts51x_pre_reset' was not declared. Should it be static? drivers/staging/rts5139/rts51x.c:229:5: warning: symbol 'rts51x_post_reset' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08Staging: rts5139: Fix Sparse Warning for Static DeclarationsMonam Agarwal1-2/+2
This patch fixes the following Sparse warnings : formatter_inquiry_str should be static queuecommand_lck should be static Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: rts5139: Fix quoted string split across linesGeorgiana Rodica Chelu1-14/+7
This patch fixes the quoted string split across lines in staging/rts5139/ms.c Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08Staging: rts5139: Fix incorrect type in assignment in rts51x_fop.cMonam Agarwal2-7/+7
This patch fixes following sparse warning in rts51x_fop.c Warning: incorrect type in assignment Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-14Staging: rts5139: rts51x_card: fixed style issuesMorgan Creekmore2-9/+9
fixed coding style issues, long lines and extra parentheses on return statement Signed-off-by: Morgan Creekmore <morgan.creekmore@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-09staging: rts5139: Drop print of build timeJosh Triplett1-1/+0
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __TIME__, which makes the build non-deterministic. (And, without __DATE__, __TIME__ provided little useful information to begin with.) Signed-off-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-17staging: delete non-required instances of include <linux/init.h>Paul Gortmaker1-1/+0
None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-17Staging: rts5139: fix parantheses coding style issue in ms.cPreetam D'Souza1-1/+1
This patch fixes an unnecessary return statement parantheses error found in ms.c by the checkpatch.pl tool. Signed-off-by: Preetam D'Souza <preetamjdsouza@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: rts5139: Replaced min() with min_t() inArchana kumari1-2/+2
This patch replaces min() with min_t() in rts51x_scsi.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-03staging: rts5139: Use correct USB transfer interval to fix syslog spammingMarcus Overhagen1-3/+3
Using correct transfer interval as specified by the USB endpoint when doing the interrupt transfer fixes the warning printed by xhci USB core on every transfer that resulted in spamming "xhci_queue_intr_tx: 74 callbacks suppressed" to syslog every 5 seconds. Signed-off-by: Marcus Overhagen <marcus.overhagen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-03staging: rts5139: Fix SD card detection on Samsung NP730U3E UltrabookMarcus Overhagen1-1/+1
The timeout detection implemented in this driver isn't very robust. Although the USB interrupt transfer was successful, the polling thread often reported timeouts because the 50ms had expired before it got scheduled, and the SD card wasn't detected. Increasing it to 100ms, as used in other places of this driver, makes it work. Signed-off-by: Marcus Overhagen <marcus.overhagen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-02Merge branch 'for-linus' of ↵Linus Torvalds2-23/+9
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs Pull VFS updates from Al Viro, Misc cleanups all over the place, mainly wrt /proc interfaces (switch create_proc_entry to proc_create(), get rid of the deprecated create_proc_read_entry() in favor of using proc_create_data() and seq_file etc). 7kloc removed. * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (204 commits) don't bother with deferred freeing of fdtables proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h proc: Make the PROC_I() and PDE() macros internal to procfs proc: Supply a function to remove a proc entry by PDE take cgroup_open() and cpuset_open() to fs/proc/base.c ppc: Clean up scanlog ppc: Clean up rtas_flash driver somewhat hostap: proc: Use remove_proc_subtree() drm: proc: Use remove_proc_subtree() drm: proc: Use minor->index to label things, not PDE->name drm: Constify drm_proc_list[] zoran: Don't print proc_dir_entry data in debug reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show() proc: Supply an accessor for getting the data from a PDE's parent airo: Use remove_proc_subtree() rtl8192u: Don't need to save device proc dir PDE rtl8187se: Use a dir under /proc/net/r8180/ proc: Add proc_mkdir_data() proc: Move some bits from linux/proc_fs.h to linux/{of.h,signal.h,tty.h} proc: Move PDE_NET() to fs/proc/proc_net.c ...
2013-04-19staging: rts5129: re-use kbasename()Andy Shevchenko1-20/+4
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. The __FILE__ macro always defined if we compile an existing file. Thus, NULL check is not needed there as well. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-04-09rts5139: switch to ->show_info()Al Viro2-23/+9
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-04-01staging: rts5139: device_reset() can be staticShawn Guo2-2/+1
Function device_reset() is only used in rts51x_scsi.c, so make it be static. Otherwise, it will have a name collision with the new added reset API. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-23staging: rts5139: fixed issues when config to built-in objectRoger Tseng19-458/+464
Fixed two issues when CONFIG_RTS5139=y : - Makefile doesn't take $(CONFIG_RTS5139). It always uses obj-m and built as a loadable module. - Rename some symbols with prefix 'rts51x_' to prevent symbol name collisions with drivers/staging/rts_pstor when both are configured to be built-in objects. drivers/staging/rts5139/built-in.o: In function `xd_cleanup_work': (.text+0x1435d): multiple definition of `xd_cleanup_work' drivers/staging/rts_pstor/built-in.o:(.text+0x2b96a): first defined here drivers/staging/rts5139/built-in.o: In function `release_xd_card': (.text+0x14393): multiple definition of `release_xd_card' drivers/staging/rts_pstor/built-in.o:(.text+0x2c491): first defined here drivers/staging/rts5139/built-in.o: In function `set_sense_data': (.text+0x1e02): multiple definition of `set_sense_data' drivers/staging/rts_pstor/built-in.o:(.text+0xa79f): first defined here drivers/staging/rts5139/built-in.o: In function `ms_delay_write': ... Signed-off-by: Roger Tseng <rogerable@realtek.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-09-26staging: rts5139: use kzalloc() to close an info leakDan Carpenter1-1/+1
If we don't fill the whole buffer then there is information leaked to the user. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-08-14staging: rts5139: substitute rts51x_dump by print_hex_dumpAndy Shevchenko1-29/+3
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-07-17staging: rts5139: rts51x_card: fixed brace coding style issueErik Jones1-2/+1
Fixed a coding style issue. An else statement was not on the same line as the preceding if statement's closing brace. Signed-off-by: Erik Jones <erik@ejnode.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-07-17staging: rts5139: rts51x_card: fixed brace coding style issueErik Jones1-4/+3
Fixed a coding style issue. Signed-off-by: Erik Jones <erik@ejnode.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-23staging: rts5139: Remove duplicate include of rts51x.hJesper Juhl1-1/+0
The header "rts51x.h" is included unconditionally at the start of the file and then again once more under "#ifdef SUPPORT_FILE_OP". Once is enough, so remove the conditional include and just keep the unconditional one. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-23staging: rts5139: rts51x_chip: fixed brace coding style issueErik Jones1-3/+2
Fixed a coding style issue. Signed-off-by: Erik Jones <erik@ejnode.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12staging: rts5139: Fix typo in rts5139Masanari Iida2-2/+2
Correct spelling typo in rts5139/rts51x_chip.h, rts51x_scsi.h Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: rts5139: sd_cprm: fix coding style and deprecation issuesAdnan Ali1-4/+4
This commit fixes coding style and deprecation issues which includes long lines, braces with single statments in if condition and deprecated min() function. Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-15staging: "rts5139" Fix typos.Justin P. Mattock6-8/+8
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused variable option.ww_enableOleksij Rempel2-16/+13
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused variable in rts51x_chip.hOleksij Rempel2-65/+1
the SENSE_TYPE_FORMAT_IN_PROGRESS was checked by rts51x_scsi.c but never set. Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused variable in rts51x.hOleksij Rempel1-4/+0
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused TUNE_SD18_*Oleksij Rempel1-6/+0
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused polling_time variableOleksij Rempel2-2/+0
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused rcc_bug_fix_enOleksij Rempel3-5/+0
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused rcc_fail_flag variableOleksij Rempel2-2/+0
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused option->needs_remote_wakeupOleksij Rempel2-2/+0
module parametr needs_remote_wakeup sets option->needs_remote_wakeup and rts51x->pusb_intf->needs_remote_wakeup the second may be used, the first one is never used Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-05-10staging: rts5139: remove unused led_blink_speed variableOleksij Rempel2-3/+0
Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.0) at 2025-03-14 11:22:50 +0300