|
Let's actually check the return value of devm_apple_tunable_parse
instead of trying to check IS_ERR on a pointer to the return value which
is always going to be valid. This prevent a oops when the tunables are
invalid or when they don't exist:
[ 57.664567] Unable to handle kernel paging request at virtual address fffffffffffffffe
[ 57.664584] Mem abort info:
[ 57.664589] ESR = 0x0000000096000007
[ 57.664595] EC = 0x25: DABT (current EL), IL = 32 bits
[ 57.664602] SET = 0, FnV = 0
[ 57.664607] EA = 0, S1PTW = 0
[ 57.664611] FSC = 0x07: level 3 translation fault
[ 57.664617] Data abort info:
[ 57.664621] ISV = 0, ISS = 0x00000007, ISS2 = 0x00000000
[ 57.664626] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[ 57.664631] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 57.664640] swapper pgtable: 16k pages, 47-bit VAs, pgdp=0000000b4391c000
[ 57.664647] [fffffffffffffffe] pgd=0000000000000000, p4d=0000000000000000, pud=0000000b44188403, pmd=0000000b4418c403, pte=0000000000000000
[ 57.664670] Internal error: Oops: 0000000096000007 [#1] SMP
[ 57.665047] CPU: 1 UID: 0 PID: 23 Comm: kworker/1:0 Tainted: G S 6.18.2+ #2 PREEMPTLAZY
[ 57.665061] Tainted: [S]=CPU_OUT_OF_SPEC
[ 57.665066] Hardware name: Apple Mac mini (M1, 2020) (DT)
[ 57.665072] Workqueue: events cd321x_update_work [tps6598x]
[ 57.665100] pstate: 61400009 (nZCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
[ 57.665111] pc : apple_tunable_apply+0x8/0x80 [apple_tunable]
[ 57.665121] lr : atcphy_mux_set+0x3e0/0x1138 [phy_apple_atc]
[ 57.665133] sp : ffffc000802a7c00
[ 57.665138] x29: ffffc000802a7c00 x28: 0000000000000003 x27: ffff800016c84080
[ 57.665151] x26: 0000000000000002 x25: ffff800016c84090 x24: ffff800016c8408f
[ 57.665163] x23: 0000000000020004 x22: 0000000000000001 x21: 0000000000000006
[ 57.665175] x20: ffff80000d6da9b0 x19: ffff80000d6da880 x18: 0000000000000002
[ 57.665188] x17: 0000000000000000 x16: ffffe22de59e0e38 x15: 0000000000000002
[ 57.665199] x14: ffffe22de76ecff8 x13: 0000000000000001 x12: ffff9dd5f90bc000
[ 57.665211] x11: 00000000000000c0 x10: 048abc15ceba0919 x9 : ffffe22dbc5fde10
[ 57.665223] x8 : ffff80000175e0d8 x7 : 0000000000000004 x6 : 0000000000000000
[ 57.665234] x5 : 0000000000000001 x4 : 0000000d6d132db7 x3 : 00000000000155db
[ 57.665246] x2 : 0000000000000000 x1 : fffffffffffffffe x0 : ffffc00082b80000
[ 57.665258] Call trace:
[ 57.665265] apple_tunable_apply+0x8/0x80 [apple_tunable] (P)
[ 57.665276] typec_mux_set+0x74/0xe0 [typec]
[ 57.665315] cd321x_update_work+0x440/0x8c0 [tps6598x]
[ 57.665332] process_one_work+0x178/0x3d0
[ 57.665346] worker_thread+0x260/0x390
[ 57.665354] kthread+0x150/0x250
[ 57.665369] ret_from_fork+0x10/0x20
[ 57.665386] Code: e69a0ae8 ffffe22d aa1e03e9 d503201f (f9400022)
[ 57.665394] ---[ end trace 0000000000000000 ]---
Reported-by: Thomas Glanzmann <thomas@glanzmann.de>
Fixes: 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY")
Signed-off-by: Sven Peter <sven@kernel.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260104-atcphy-tunable-fix-v2-1-84e5c2a57aaa@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
|
|
The Apple Type-C PHY (ATCPHY) is a PHY for USB 2.0, USB 3.x,
USB4/Thunderbolt, and DisplayPort connectivity found in Apple Silicon SoCs.
The PHY handles muxing between these different protocols and also provides
the reset controller for the attached dwc3 USB controller.
There is no documentation available for this PHY and the entire sequence
of MMIO pokes has been figured out by tracing all MMIO access of Apple's
driver under a thin hypervisor and correlating the register reads/writes
to their kernel's debug output to find their names. Deviations from this
sequence generally results in the port not working or, especially when
the mode is switched to USB4 or Thunderbolt, to some watchdog resetting
the entire SoC.
This initial commit already introduces support for Display Port and
USB4/Thunderbolt but the drivers for these are not ready. We cannot
control the alternate mode negotiation and are stuck with whatever Apple's
firmware decides such that any DisplayPort or USB4/Thunderbolt device will
result in a correctly setup PHY but not be usable until the other drivers
are upstreamed as well.
Co-developed-by: Janne Grunau <j@jannau.net>
Signed-off-by: Janne Grunau <j@jannau.net>
Co-developed-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> # for reset controller
Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Sven Peter <sven@kernel.org>
Link: https://patch.msgid.link/20251214-b4-atcphy-v3-3-ba82b20e9459@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
|
