summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorWander Lairson Costa <wander@redhat.com>2026-02-23 19:18:00 +0300
committerGabriele Monaco <gmonaco@redhat.com>2026-04-01 11:16:20 +0300
commit957dcbf0b663385dddb3eaa5cf5de5109255696f (patch)
tree542f78abbcb2abb736e64527e91ead1273a0209d /tools
parent2074723f518173cbad400a48021971cb82481e81 (diff)
downloadlinux-957dcbf0b663385dddb3eaa5cf5de5109255696f.tar.xz
rv/rvgen: enforce presence of initial state
The __get_state_variables() method parses DOT files to identify the automaton's initial state. If the input file lacks a node with the required initialization prefix, the initial_state variable is referenced before assignment, causing an UnboundLocalError or a generic error during the state removal step. Initialize the variable explicitly and validate that a start node was found after parsing. Raise a descriptive AutomataError if the definition is missing to improve debugging and ensure the automaton is valid. Signed-off-by: Wander Lairson Costa <wander@redhat.com> Reviewed-by: Gabriele Monaco <gmonaco@redhat.com> Link: https://lore.kernel.org/r/20260223162407.147003-18-wander@redhat.com Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/verification/rvgen/rvgen/automata.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/verification/rvgen/rvgen/automata.py b/tools/verification/rvgen/rvgen/automata.py
index 9fa17216ca52..b9f8149f7118 100644
--- a/tools/verification/rvgen/rvgen/automata.py
+++ b/tools/verification/rvgen/rvgen/automata.py
@@ -145,6 +145,7 @@ class Automata:
# wait for node declaration
states = []
final_states = []
+ initial_state = ""
has_final_states = False
cursor = self.__get_cursor_begin_states()
@@ -171,6 +172,9 @@ class Automata:
final_states.append(state)
has_final_states = True
+ if not initial_state:
+ raise AutomataError("The automaton doesn't have an initial state")
+
states = sorted(set(states))
states.remove(initial_state)