diff options
author | James Clark <james.clark@linaro.org> | 2025-02-26 17:55:25 +0300 |
---|---|---|
committer | Namhyung Kim <namhyung@kernel.org> | 2025-03-03 23:48:17 +0300 |
commit | be9f3e95a93896d23d33c9bcda1c9736121e349d (patch) | |
tree | e42ffac97211cfb484fd92751096c96f50f29bb2 /tools/perf/util/trace-event-scripting.c | |
parent | 7788ad59d1d9617792037a83513be5b1dd14150f (diff) | |
download | linux-be9f3e95a93896d23d33c9bcda1c9736121e349d.tar.xz |
perf stat: Fix non-uniquified hybrid legacy events
Legacy hybrid events have attr.type == PERF_TYPE_HARDWARE, so they look
like plain legacy events if we only look at attr.type. But legacy events
should still be uniquified if they were opened on a non-legacy PMU. Fix
it by checking if the evsel is hybrid and forcing needs_uniquify
before looking at the attr.type.
This restores PMU names on hybrid systems and also changes "perf stat
metrics (shadow stat) test" from a FAIL back to a SKIP (on hybrid). The
test was gated on "cycles" appearing alone which doesn't happen on
here.
Before:
$ perf stat -- true
...
<not counted> instructions:u (0.00%)
162,536 instructions:u # 0.58 insn per cycle
...
After:
$ perf stat -- true
...
<not counted> cpu_atom/instructions/u (0.00%)
162,541 cpu_core/instructions/u # 0.62 insn per cycle
...
Fixes: 357b965deba9 ("perf stat: Changes to event name uniquification")
Suggested-by: Ian Rogers <irogers@google.com>
Signed-off-by: James Clark <james.clark@linaro.org>
Tested-by: Thomas Falcon <thomas.falcon@intel.com>
Link: https://lore.kernel.org/r/20250226145526.632380-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions