diff options
| author | Athira Rajeev <atrajeev@linux.vnet.ibm.com> | 2024-10-13 20:07:32 +0300 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2024-10-14 20:29:55 +0300 |
| commit | 9ea671d1b2d5962368b94b28507ae65f94c86fb3 (patch) | |
| tree | 66b713cd47d9237bc1a7ef747e7ae8196c4cba7e /tools/perf/tests | |
| parent | d94d86cee1032bbf429d5bd0914b064e03b56f0e (diff) | |
| download | linux-9ea671d1b2d5962368b94b28507ae65f94c86fb3.tar.xz | |
tools/perf/tests: Remove duplicate evlist__delete in tests/tool_pmu.c
The testcase for tool_pmu failed in powerpc as below:
./perf test -v "Parsing without PMU name"
8: Tool PMU :
8.1: Parsing without PMU name : FAILED!
This happens when parse_events results in either skip or fail
of an event. Because the code invokes evlist__delete(evlist)
and "goto out".
ret = parse_events(evlist, str, &err);
if (ret) {
evlist__delete(evlist);
But in the "out" section also evlist__delete happens.
out:
evlist__delete(evlist);
return ret;
Hence remove the duplicate evlist__delete from the first path
in the testcase
With the change:
# ./perf test -v "Parsing without PMU name"
8: Tool PMU :
8.1: Parsing without PMU name : Ok
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: akanksha@linux.ibm.com
Cc: hbathini@linux.ibm.com
Cc: kjain@linux.ibm.com
Cc: maddy@linux.ibm.com
Cc: disgoel@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org
Link: https://lore.kernel.org/r/20241013170732.71339-1-atrajeev@linux.vnet.ibm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/tests')
| -rw-r--r-- | tools/perf/tests/tool_pmu.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/perf/tests/tool_pmu.c b/tools/perf/tests/tool_pmu.c index 297cc8c55579..46896b485abf 100644 --- a/tools/perf/tests/tool_pmu.c +++ b/tools/perf/tests/tool_pmu.c @@ -27,7 +27,6 @@ static int do_test(enum tool_pmu_event ev, bool with_pmu) parse_events_error__init(&err); ret = parse_events(evlist, str, &err); if (ret) { - evlist__delete(evlist); if (tool_pmu__skip_event(tool_pmu__event_to_str(ev))) { ret = TEST_OK; goto out; |