diff options
author | Justin Stitt <justinstitt@google.com> | 2023-09-20 11:08:52 +0300 |
---|---|---|
committer | Wolfram Sang <wsa@kernel.org> | 2023-09-22 13:10:24 +0300 |
commit | e2def33f9ee1b1a8cda4ec5cde69840b5708f068 (patch) | |
tree | 62ea6d3e51a8ef7af8312b9d060644f7361395a0 /tools/perf/scripts/python | |
parent | 0c051c824912f149b66d2ede42dcfd2ae871b2a1 (diff) | |
download | linux-e2def33f9ee1b1a8cda4ec5cde69840b5708f068.tar.xz |
i2c: cp2615: replace deprecated strncpy with strscpy
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
We expect name to be NUL-terminated based on its numerous uses with
functions that expect NUL-terminated strings.
For example in i2c-core-base.c +1533:
| dev_dbg(&adap->dev, "adapter [%s] registered\n", adap->name);
NUL-padding is not required as `adap` is already zero-alloacted with:
| adap = devm_kzalloc(&usbif->dev, sizeof(struct i2c_adapter), GFP_KERNEL);
With the above in mind, a suitable replacement is `strscpy` [2] due to
the fact that it guarantees NUL-termination on the destination buffer
without unnecessarily NUL-padding.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions