summaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python
diff options
context:
space:
mode:
authorClemens Noss <cnoss@gmx.de>2011-05-16 00:50:46 +0400
committerGreg Kroah-Hartman <gregkh@suse.de>2011-05-18 00:31:30 +0400
commitaacd531df9b88f7419e22708f72a476030863efe (patch)
tree27c1517b7daf24a7c7a28c6c1169ca536dee39aa /tools/perf/scripts/python
parent84067de664ee6adba8c373e4298d755abd783b24 (diff)
downloadlinux-aacd531df9b88f7419e22708f72a476030863efe.tar.xz
staging: brcm80211: use correct pointer types in bcm_pktq_flush
to clarify the intention: On Sun, May 15, 2011 at 09:54:26PM +0200, Arend van Spriel wrote: > On 05/15/2011 08:10 PM, Hauke Mehrtens wrote: [...] >> Why don't you use the correct pointer type here instead of casting then >> around and the parameter names are meaningless too. >> >> static bool cb_del_ampdu_pkt(struct sk_buff *mpdu, struct >> cb_del_ampdu_pars *ampdu_pars) [...] > Actually this is a generic callback mechanism in which an additional > parameter can be passed, which can be of *any* type hence a void pointer > seems justified here and a meaningless name is used. I do agree that the > txi parameter will always be a struct sk_buff and should be indicated as > such. Reported-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: Clemens Noss <cnoss@gmx.de> Acked-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions