diff options
author | Taehee Yoo <ap420073@gmail.com> | 2025-04-02 16:31:23 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-04-04 01:10:52 +0300 |
commit | e4546c6498c68ba65929fcbcf54ff1947fe53f48 (patch) | |
tree | 21da035d415fd90602fcc956635a18f67dbe91f8 /tools/perf/scripts/python/task-analyzer.py | |
parent | e5ddf19dbc3e24cce508de0dab0e8df5b7417de8 (diff) | |
download | linux-e4546c6498c68ba65929fcbcf54ff1947fe53f48.tar.xz |
eth: bnxt: fix deadlock in the mgmt_ops
When queue is being reset, callbacks of mgmt_ops are called by
netdev_nl_bind_rx_doit().
The netdev_nl_bind_rx_doit() first acquires netdev_lock() and then calls
callbacks.
So, mgmt_ops callbacks should not acquire netdev_lock() internaly.
The bnxt_queue_{start | stop}() calls napi_{enable | disable}() but they
internally acquire netdev_lock().
So, deadlock occurs.
To avoid deadlock, napi_{enable | disable}_locked() should be used
instead.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Fixes: cae03e5bdd9e ("net: hold netdev instance lock during queue operations")
Link: https://patch.msgid.link/20250402133123.840173-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions